-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notification delay with doorbell_graham_cracker #1280
Conversation
* The low cost wired Ring doorbell cannot take snapshots whilst recording which leads to a ~15sec delay in the HomeKit notifications. This patch bypasses the snapshot load for these devices only. See issue dgreif#933.
@dgreif What do you think? My gut says that, while this works, I'm not sure if this is the ideal place to fix this, for one camera model, OK, but my guess is there will be more. I feel like a better approach is to impement some type of capability flag (not sure of the name, maybe I do have a suspicion that any camera that can't do this will have a "run_mode" of "low_power", but I don't have access to enough models to prove that. Some cameras, mostly stickup cams I believe, but maybe spotlight cams too, support different run modes based on if their power source is battery, solar, or plug and based on settings in the app. @townsen Any chance you could provide a data discovery of this camera to see what run mode it reports? |
@tsightler I agree that a capability flag would be more elegant and generic, but I'm not sure how to check that. I've looked at the Data Discovery (I did one way back in #933, and repeated it today - see below) and I see nothing obvious, but I'm no expert. So although this is hardcode perhaps it's the only way. I do see an argument to move it further back into the ring-client-api as you suggest. Let's see what @dgreif thinks. I did this now as I'm off on vacation (which is what pushed me to make this fix!) so won't be able to refactor the PR until September. |
Data Discovery taken today using NodeJS v18.16.0 and |
Hi there, Im having this same issue with Hoobs. How can I implement a fix? |
Sorry this lingered so long, it definitely fell off my radar 😞. I ended up adding |
How can I update to the beta from hoobs? |
HOOBS questions are best asked to HOOBS support, I'm sure there is some way in the UI to select the version. |
Again, HOOBS support is your best path for support questions for HOOBS, none of us, as maintaners of a Homebridge plugin, use HOOBS and it has a different UI from Homebridge. Most likely it just hasn't refreshed the available versions yet but nobody here is going to have any idea how to do it, however, that's the primary benefit of paying for HOOBS, to have somebody to ask such questions, so you should reach out to them. |
I see, thanks for fixing the issue ;) |
The low cost wired Ring doorbell (aka 'Graham Cracker') cannot take snapshots whilst recording which leads to a ~15sec delay in the HomeKit notifications. This patch bypasses the snapshot load for these devices only. See issue #933.